Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailwindui css layout support - colon is not accepted by the pattern #791

Closed
wants to merge 6 commits into from
Closed

Tailwindui css layout support - colon is not accepted by the pattern #791

wants to merge 6 commits into from

Conversation

in-session
Copy link
Contributor

@in-session in-session commented Nov 10, 2021 •
edited by m2-assistant bot
Loading

@in-session in-session mentioned this pull request Dec 2, 2021
Closed
@sdzhepa sdzhepa added the Priority: P2 Priority: P2 label May 5, 2022
@paras89
Copy link
Contributor

paras89 commented Jun 20, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@paras89
Copy link
Contributor

paras89 commented Jun 21, 2022

@in-session can you pull develop branch into your fork's branch and re-run the tests? After that once the test results are out I can help you fix them!

@in-session
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@in-session
Copy link
Contributor Author

@magento run Functional Tests B2B Functional Tests EE

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@in-session
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@paras89
Copy link
Contributor

paras89 commented Jun 27, 2022

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@in-session
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@in-session
Copy link
Contributor Author

I think failing tests are not related to changes from this PR

@paras89
Copy link
Contributor

paras89 commented Jul 28, 2022

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Bravo
Copy link
Collaborator

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Before: ✖️ 

colon is not accepted by the pattern.

After: ✔️  

colon is accepted by the pattern.

Thanks.

@engcom-Hotel engcom-Hotel added the Project: Community Picked PRs upvoted by the community label Mar 4, 2024
@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests

@engcom-Hotel engcom-Hotel added Project: Community Picked PRs upvoted by the community and removed Project: Community Picked PRs upvoted by the community labels Apr 30, 2024
@engcom-Hotel
Copy link
Collaborator

We can close this PR as it has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@Den4ik Den4ik Den4ik approved these changes

@fredden fredden fredden approved these changes

Assignees

@fredden fredden

Labels
Priority: P2 Priority: P2 Project: Community Picked PRs upvoted by the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Tailwindui css layout support - colon is not accepted by the pattern
8 participants
@in-session @paras89 @engcom-Hotel @engcom-Bravo @fredden @Den4ik @ihor-sviziev @sdzhepa