Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy gets executed after autoload generation #106

Open
Flyingmana opened this issue Jun 8, 2014 · 2 comments
Open

deploy gets executed after autoload generation #106

Flyingmana opened this issue Jun 8, 2014 · 2 comments

Comments

@Flyingmana
Copy link
Member

i noticed the autoload generation currently happens before the deploy, causes problems with composer autoloading for magento files. (anyone used/tried this besides me, or Iam the only one?)

@tkdb
Copy link
Contributor

tkdb commented Jun 18, 2014

If you leave a little notice how to test, I can consider to replay with the tests I also have in my TODO for #100 and #99.

@davidverholen
Copy link

when you look at the Composer\Installer at line 294...

$this->autoloadGenerator->setDevMode($this->devMode);
$this->autoloadGenerator->dump($this->config, $localRepo, $this->package, $this->installationManager, 'composer', $this->optimizeAutoloader);

if ($this->runScripts) {
        // dispatch post event
        $eventName = $this->update ? ScriptEvents::POST_UPDATE_CMD : ScriptEvents::POST_INSTALL_CMD;
        $this->eventDispatcher->dispatchCommandEvent($eventName, $this->devMode);
}

autoload is generated before the deployment because the deploymanager is called in the post install/update event handler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants