File tree Expand file tree Collapse file tree 2 files changed +6
-2
lines changed Expand file tree Collapse file tree 2 files changed +6
-2
lines changed Original file line number Diff line number Diff line change @@ -21,7 +21,11 @@ function execute(O $o):void {
21
21
# 2019-09-22 I have removed the `!df_product_type_composite($p)` condition.
22
22
$ p ['color ' ] === $ p ->getOrigData ('color ' )
23
23
# 2019-08-21 A new image path can start with `#` because of a Magento 2 core bug.
24
- && ($ path = df_trim_text_right (df_path_n ($ p ['image ' ]), '.tmp ' )) !== df_path_n ($ p ->getOrigData ('image ' ))
24
+ # 2023-08-01
25
+ # «df_path_n(): Argument #1 ($p) must be of type string, null given,
26
+ # called in vendor/mage2pro/color/Observer/ProductSaveBefore.php on line 24»:
27
+ # https://github.com/mage2pro/color/issues/4
28
+ && ($ path = df_trim_text_right (df_path_n ($ p ['image ' ]), '.tmp ' )) !== df_path_n (df_nts ($ p ->getOrigData ('image ' )))
25
29
) {
26
30
/** @var string $path */
27
31
$ full1 = df_product_image_path2abs ($ path ); /** @var string $full1 */
Original file line number Diff line number Diff line change 1
1
{
2
2
"name" : " mage2pro/color"
3
- ,"version" : " 1.2.1 "
3
+ ,"version" : " 1.2.2 "
4
4
,"description" : " A product image color categorization module for Magento 2"
5
5
,"type" : " magento2-module"
6
6
,"homepage" : " https://mage2.pro/c/extensions/color"
You can’t perform that action at this time.
0 commit comments