feat: provision to have test runners #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
jamesgeorge007
requested changes
Dec 27, 2019
Comment on lines
+87
to
+89
| if (testRunner === 'ava' && template === 'nuxt') { | ||
| return; | ||
| } |
There was a problem hiding this comment.
It seems Nuxt.js works pretty much with Ava. Can you clarify about this early return?
| { | ||
| name: 'testRunner', | ||
| type: 'list', | ||
| message: 'Please select your test framework for your project', |
There was a problem hiding this comment.
Suggested change
| message: 'Please select your test framework for your project', | |
| message: 'Please select the test framework of choice', |
|
|
||
| process.chdir(`${projectName}/client/`); | ||
|
|
||
| const fetchSpinner = new Spinner(`Installing the ${testRunner}`); |
There was a problem hiding this comment.
Suggested change
| const fetchSpinner = new Spinner(`Installing the ${testRunner}`); | |
| const fetchSpinner = new Spinner(`Installing ${testRunner}`); |
jamesgeorge007
changed the title
|
closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added user prompt to choose which test framework to proceed with.
Fixes #82
Please delete options that are not relevant.
Checklist: