Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting core_email and core_email_template gives conflicts #77

Open
sandermangel opened this issue Mar 23, 2016 · 3 comments
Open
Milestone

Comments

@sandermangel
Copy link
Contributor

A few frequently used email modules like Ashroder_Smtp, mailchimp and dotmailer rewrite the core_email and core_email_template models.

Is there any other way to do the profiling on emails than a rewrite or maybe make it optional?

https://github.com/madalinoprea/magneto-debug/blob/master/code/Debug/etc/config.xml#L27

@madalinoprea
Copy link
Owner

Hi @sandermangel,

I'm going to think about it. I agree that this extension shouldn't have this side effect.

Currently I'm going to see if we can apply this solution https://github.com/Danack/intahwebz-examples/tree/master/src/Intahwebz/Examples/DynamicInheritance

Or add the rewrites dynamically only if we can handle core/email_template implementation.

@sandermangel
Copy link
Contributor Author

Great! Thanks for that. Looks like a nice option to fix the issue

@madalinoprea madalinoprea added this to the 1.9.0 milestone Apr 22, 2016
@sandermangel
Copy link
Contributor Author

@madalinoprea wasn't this fixed in the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants