-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to build against OpenSSL version 1.1.0g #18
Comments
@erikd do we have a work around for this? |
We? I don't. No idea if anyone else does. |
In OpenSSL 1.1.x the function OpenSSL_add_all_ciphers was deprecated and replaced with OPENSSL_init_crypto: https://www.openssl.org/docs/man1.1.0/crypto/OpenSSL_add_all_ciphers.html in configure.ac I replaced the OpenSSL_add_all_ciphers line with this: AC_CHECK_LIB([crypto], [OPENSSL_init_crypto], , [have_libcrypto="0"]) then reran autogen.sh and that fixes the build for me on Fedora 26. At first glance xar seems to run fine. |
@armijnhemel Would be great if could you raise a PR with those changes. |
I will first need to run a few more tests to see if it actually works as expected before I create a PR. Also, this change will break building with openssl 1.0.x and I would also need to work around that. |
Obviously, this is not my project, but I honestly don't think backwards compatibility with an older version of OpenSSL is an important factor. OpenSSL is an important security related library with a somewhat checkered history security wise. Supporting old, possible broken versions doesn't make a lot of sense, especially since 1.1.* has been out for for over a year. See https://www.openssl.org/news/openssl-1.1.0-notes.html |
The change @ErikGoldman did here https://github.com/loft-box-labs/xar/commit/bab8837fd993385115d58763e15487dc8cc13f97 (probably via #18 (comment)) worked perfectly for me. |
OpenSSL 1.1.0 deprecated OpenSSL_add_all_algorithms and replaced with OPENSSL_init_crypto. Ref: mackyle/xar#18 Ref: https://trac.macports.org/ticket/52101
This is still broken, or possibly broken again. I have followed the suggestions her, but still missing libcrypto. I suspect that it is because the standard version for Ubuntu 18.04 is now openssl v1.1.1.g and the dev library is just 1.1 |
Same here on Debian testing. I have libssl-dev 1.1.1h-1 and libcrypt-dev 1:4.4.17-1 installed. No progress. |
The last commit to the master branch has been made in 2014 - I guess this project is no longer active and the chances that one of the proposed pull requests will ever be merged are pretty thin. @mackyle Do you have an update on the project status? Please? :-D |
I used LibreSSL built locally since it is OpenSSL v1.0.0 compatible. It is pretty simple to build because it uses CMake, then I just install in a local directory and pass the CFLAGS and LDFLAGS to the ./configure command |
#Configure fails at:
I have OpenSSL version 1.1.0g instatlled.
I'd fix this, but I'm already to deep down the yak stack.
The text was updated successfully, but these errors were encountered: