-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-machine is closed, so if we want it to continue, we need to start releasing #4
Comments
At the moment machine is more important to us... and not even in binary form (we only compile and link to the library; same for minikube) @praveenkumar @LalatenduMohanty @dlorenc @aaron-prindle @r2d4 WDYT? |
At this moment docker machine as library is important for us. May be we can release the binary too (in future if we get some new features). |
at the origin's repo they only used:
which is easy to replicate. |
ALso, should this remain a fork... or should we break this reference and re-import as a 'new' project? |
Right for us (minishift + minikube) are going to use as library but if they are closing the project down then might be in future we need to build binary out of it also. |
to use Circle CI for macOS we need to send an email, and for AppVeyor we need a dedicated account |
@praveenkumar it depends. do we really want to use a |
Seems like continuing Docker Machine and Docker Toolbox is a huge task, if not even Docker Inc. wants to do it... Better focus on libmachine, perhaps even in a separate git repository (like with the kvm2 driver) ?
Like it says, that mcndirs should probably be removed: vendor/github.com/docker/machine/libmachine/provision/boot2docker.go: // TODO: Ideally, we should not read from mcndirs directory at all.
vendor/github.com/docker/machine/libmachine/provision/boot2docker.go: b2dutils := mcnutils.NewB2dUtils(mcndirs.GetBaseDir()) And the drivers are handled a bit differently, by minikube... |
libmachine is already forked and has been setup for CI
…On Mon, Jul 30, 2018 at 10:13 PM, Anders Björklund ***@***.*** > wrote:
Seems like continuing Docker Machine and Docker Toolbox is a huge task, if
not even Docker Inc. wants to do it... Better focus on *libmachine*,
perhaps even in a separate git repository (like with the *kvm2* driver) ?
- github.com/docker/machine/commands/mcndirs
- *github.com/docker/machine/drivers
<http://github.com/docker/machine/drivers>*
- *github.com/docker/machine/libmachine
<http://github.com/docker/machine/libmachine>*
- github.com/docker/machine/version
Like it says, that *mcndirs* should probably be removed:
vendor/github.com/docker/machine/libmachine/provision/boot2docker.go: // TODO: Ideally, we should not read from mcndirs directory at all.
vendor/github.com/docker/machine/libmachine/provision/boot2docker.go: b2dutils := mcnutils.NewB2dUtils(mcndirs.GetBaseDir())
And the drivers are handled a bit differently, by minikube...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAHZhjFcpS0bGGufZoyGHvKqrNesYWPks5uLxSTgaJpZM4VQc61>
.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
@gbraad : also including the commands and everything, right ? (i.e. this repo) |
What do you mean with commands? We are unlikely to release a binary (app)
from this repo.
|
Ah, right. I thought that @SvenDowideit suggested doing just that (making new releases of Which means that theoretically it could use a different "libmachine-only" version of the repository, without the commands and without the cloud drivers. That would make it more of a outright fork, then just continuing hosting the old repository. |
right, we could create a new binary, but it would like have to be under a
new name, like 'container-machine', plus removal of all the trademarks and
mention of Docker.
We will discuss this soon with Minikube; @praveenkumar might be able to
invite you too
|
tbh, I was thinking that we'd just call it |
I am fine either way... for me it is about continued maintenance and
possibly some refactoring.
|
Not sure if the changes to the PR template are desired ?
But it would be nice to make things clear about support level, if it is "only" libmachine and drivers ? There is already quite a difference in Docker versions, between boot2docker and minikube/minishift. |
What did we decide here? I think we should probably drop the releases and binaries and make it clear that this is only about supporting libmachine and drivers. |
@dlorenc : I think that makes sense, and it seems like Docker will still maintain the old binaries for people who want their "legacy" solution (don't run Win or Mac)... Do you need to actually change something in this repository, or is it just making it clear in the README or something - that is only intended as a library dependency ? |
I'd like to make it clear in the readme, close this issue and then potentially delete the code/deps we no longer need. |
Did a short list previously (above), it looked straight-forward - except for that "mcnutils" thingie. It could potentially be a future problem, if people want to use the drivers provided by this repository for the original machine implementation (docker) that is "frozen" in specificaiton if the library implemention (machine-drivers) drifts away from that by adding features or continuing to evolve. But right now, it's "close enough" that they should probably work for both ? There's already a selection of ISO images... |
Yeah changing the interface will be troublesome. Your proposal of what to delete makes a lot of sense. |
I think this makes sense - any idea how to break the reference? |
@SvenDowideit : There are no changes (compared to |
Leaving this at v0.16.1 (now with two backported commits) |
see docker#4537
I'm also wondering if toolbox is needed too - there are users that don't use hyper-v, or simply have different goals :/
The text was updated successfully, but these errors were encountered: