Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y-Offsets #4

Closed
hermannkleier opened this issue Sep 8, 2013 · 4 comments
Closed

Y-Offsets #4

hermannkleier opened this issue Sep 8, 2013 · 4 comments

Comments

@hermannkleier
Copy link

I use a Rigol DS1102E. Could be that the issue cannot be observed on the DS1052.

I had a waveform recorded with "Y grid scale: 5.000e-01 V/div, Y shift: -1.500e-01 V". The information was transmitted in the wfm-file header and parsed by wfmutil.py correctly.

Edit: "Y shift" was -1.5 V on the DS1102E. Therefore, the value was parsed incorrectly. I missed that initially.

To convert to "real" voltages I use the formula (125 - $1) * 0.02 + 1.5), $1 being an unsigned byte value from the data array. The results match the displayed data on the scope.

In the contrary, the "wfmutil.py csv" values are shifted by -1.65V. I.e., instead of real 0V, the csv-file contains -1.65V.

Just a guess: Looks like "Y shift" is parsed too small (by a factor of 10) and considered with the wrong sign.

@mabl
Copy link
Owner

mabl commented Sep 8, 2013

Hi Hermann,

thank you for the bug report. Did you shift the Y-Offset on the oscilloscope after you have stopped the measurement? This might be related to issue #2.

@hermannkleier
Copy link
Author

Hi Matthias,

thank you for the prompt reply.

On Sun, 8 Sep 2013, Matthias Blaicher wrote:

Hi Hermann,

thank you for the bug report. Did you shift the Y-Offset after you have stopped the measurement? This might be related to issue #2.

no, I didn't. I had observed that the sequence of setups is critical
for the Rigol device. So I marked down the procedure. That way I got a
more detailed protocol (and the context) at

http://cross.kleier.selfhost.me/1wire_rigol.php

It is just a notepad, though.

Greetings,

Hermann


Reply to this email directly or view it on GitHub:
#4 (comment)

mabl added a commit that referenced this issue Sep 9, 2013
There was an embarrassing error when caluclating the shift offset.
The value was wrong by a factor of ten and shifted in the wrong
direction.

This fixes issue #4.
@mabl
Copy link
Owner

mabl commented Sep 9, 2013

Hi Hermann,

you were right... The shift calculation was wrong the whole time. I've fixed the problem and it should work for you now. I'm sorry for your troubles.

@mabl mabl closed this as completed Sep 9, 2013
@hermannkleier
Copy link
Author

Hi Matthias,

On Mon, 9 Sep 2013, Matthias Blaicher wrote:

thanks a lot for the quick fix.

Hi Hermann,

you were right... The shift calculation was wrong the whole
time. I've fixed the problem and it should work for you now. I'm
sorry for your troubles.

And thank you for sharing the code.

Hermann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants