Fixes issue discussed in #236, random exceptions being thrown when cache expires. Assumption about a potential memory leak because of circular references was incorrect, so there is no need for the SiteMapLoader to call the ISiteMap.Clear() method when the cache expires. Confirmed by adding extra buffer to the SiteMapNode and setting cache duration to 0 that memory is not leaking in this case.

Author: NightOwl888

src/MvcSiteMapProvider/MvcSiteMapProvider/Loader/SiteMapLoader.cs

@@ -27,11 +27,6 @@ ISiteMapCreator siteMapCreator
             this.siteMapCache = siteMapCache;
             this.siteMapCacheKeyGenerator = siteMapCacheKeyGenerator;
             this.siteMapCreator = siteMapCreator;
-
-            // Attach an event to the cache so when the SiteMap is removed, the Clear() method can be called on it to ensure
-            // we don't have any circular references that aren't GC'd.
-            siteMapCache.ItemRemoved += new EventHandler<MicroCacheItemRemovedEventArgs<ISiteMap>>(siteMapCache_ItemRemoved);
-
         }
 
         protected readonly ISiteMapCache siteMapCache;
@@ -72,12 +67,5 @@ public virtual void ReleaseSiteMap(string siteMapCacheKey)
         }
 
         #endregion
-
-        protected virtual void siteMapCache_ItemRemoved(object sender, MicroCacheItemRemovedEventArgs<ISiteMap> e)
-        {
-            // Call clear to remove ISiteMapNode object references from internal collections. This
-            // will release the circular references and free the memory.
-            e.Item.Clear();
-        }
     }
 }