Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button builder broken #433

Closed
4 tasks done
Slender4fun opened this issue Oct 9, 2024 · 11 comments
Closed
4 tasks done

button builder broken #433

Slender4fun opened this issue Oct 9, 2024 · 11 comments
Labels
bug Undesired behavior caused by this plugin

Comments

@Slender4fun
Copy link

Slender4fun commented Oct 9, 2024

Please fill out these Check-boxes

  • I checked for existing similar issues
  • I checked that the plugin is up to date
  • The issue persists with all other plugins and themes disabled

Plugin Version

1.2.1

This Issue Occurs on

  • macOS

Debug Info

SYSTEM INFO:
	Obsidian version: v1.6.7
	Installer version: v1.4.14
	Operating system: Darwin Kernel Version 22.6.0: Mon Apr 22 20:49:37 PDT 2024; root:xnu-8796.141.3.705.2~1/RELEASE_ARM64_T6000 22.6.0
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Base theme: adapt to system
	Community theme: none
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 3
	Plugins enabled: 1
		1: Meta Bind v1.2.1

RECOMMENDATIONS:
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Describe the Issue

if i add any otehr function than "input" or "command" the button-builder does not show the action added. if i first add one of the above, then an other (no visible change) and then delete the first object, only the title changes and shows the second added item. action context does not change ( so my title is now "open link" but the text below says "the text to input at the cursor")

grafik

Steps to Reproduce

install newest plugin version.
try to build a button

Expected Behavior

shows growing list of actions under the "actions" heading in the button-builder

@Slender4fun Slender4fun added the bug Undesired behavior caused by this plugin label Oct 9, 2024
@mProjectsCode
Copy link
Owner

Can you check if this issue persists in version 1.2.2?

@Slender4fun
Copy link
Author

Slender4fun commented Oct 10, 2024

if i "add action" for "open" noting happens. i can now also not add any other action. have to reopen the button configurator.

if i add "command" it appears normal. then i add "open", nothing happens. then i "move down" the first action. the scrollbar got longer just now. Above is now the title of "open a link" but no context under it.

grafik

edit: i think every other action except "open" works now normall.

debuginfo:
SYSTEM INFO:
Obsidian version: v1.6.7
Installer version: v1.4.14
Operating system: Darwin Kernel Version 22.6.0: Mon Apr 22 20:49:37 PDT 2024; root:xnu-8796.141.3.705.2~1/RELEASE_ARM64_T6000 22.6.0
Login status: not logged in
Insider build toggle: off
Live preview: on
Base theme: adapt to system
Community theme: none
Snippets enabled: 0
Restricted mode: off
Plugins installed: 1
Plugins enabled: 1
1: Meta Bind v1.2.2

RECOMMENDATIONS:
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

@motion2082
Copy link

Seems to add the Open but you need to edit in source mode. If you try to add as a template it doesn't work at all

@motion2082
Copy link

error
error2
Uploading error3.png…

@motion2082
Copy link

Meta Bind v1.2.3

Meta Bind Button Builder

Error when Adding OPEN Action
open-error

@mProjectsCode
Copy link
Owner

This button builder is driving me insane :(

@mProjectsCode
Copy link
Owner

The last problem from @motion2082 screenshot should be fixed in 1.2.4

@motion2082
Copy link

motion2082 commented Oct 29, 2024

Appreciate you pushing out 2 updates in the past week to try fix it. I was just using an older version in between updates.

Sidenote, I edit buttons in the source code for the broken Open Command. For the broken Edit Template Button inside settings I don’t use this yet. A work around atm is to open data.json templates code editor.

Outstanding issues I’m having:

  1. The Button Template Builder Edit button feature is still broken in 1.2.4 by the looks.

  2. Adding Open Command also still isn’t working in 1.2.4

I will test on another Vault tomorrow as I have about 38 plugins in my Production Vault.

@mProjectsCode
Copy link
Owner

Oh, in 1.2.4 I fixed the issue new buttons, but I didn't account for "broken" buttons in the template buttons.

@mProjectsCode
Copy link
Owner

I just released a better fix in 1.2.5 that should work with existing templates and does not require any migrations.

@motion2082
Copy link

Thank you so much Moritz

Both the Template Editor and Open Feature in Button Builder are now fixed in 1.2.5

I have an exciting project in the works related to your Plugin, will share it with you when it's completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behavior caused by this plugin
Projects
None yet
Development

No branches or pull requests

3 participants