Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the locate service to retrieve a server #5

Open
bassosimone opened this issue Jul 24, 2019 · 1 comment
Open

Use the locate service to retrieve a server #5

bassosimone opened this issue Jul 24, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bassosimone
Copy link
Contributor

As specified in the spec of ndt7, we should use the locate service to find out the closest server and then run the test with such server. As pointed out by many this repository is still using an hardcoded server name, which is the IP address of a GCE instance I used for testing.
@bassosimone bassosimone added enhancement New feature or request help wanted Extra attention is needed labels Jul 24, 2019
fulvius31 added a commit to fulvius31/ndt7-client-android that referenced this issue Aug 2, 2019
@fulvius31
- Solved issue (m-lab#5)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
c04f96e 
- First raw layout
- Some change to previous client
- First upload prototype
@bassosimone bassosimone mentioned this issue Aug 17, 2019
Closed
@stevepopovich
Copy link

Is this still the case? New to this source code, but it looks like the library does this:

ndt7-client-android/libndt7/src/main/java/net/measurementlab/ndt7/android/NDTTest.kt

Line 113 in 3e831b7

private fun getHostname(): Call? {

ndt7-client-android/libndt7/src/main/java/net/measurementlab/ndt7/android/NDTTest.kt

Line 42 in 3e831b7

getHostname()?.enqueue(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bassosimone @stephen-soltesz @stevepopovich