Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge simple changes from #234 to master #242

Open
bassosimone opened this issue Feb 4, 2020 · 0 comments · May be fixed by #252
Open

Merge simple changes from #234 to master #242

bassosimone opened this issue Feb 4, 2020 · 0 comments · May be fixed by #252
Assignees
@bassosimone
Labels
2020-02-meeting To discuss during 2020-02-meeting

Comments

@bassosimone
Copy link
Contributor

This basically amounts to:

  1. fixes that propagate the current start time correctly

  2. fixes that make sure we send a single RTT sample

It should also be an interesting follow-up to consider how refactoring the channels as discussed in #238 can be helpful to actually allow to save application-level measurement samples.
@bassosimone bassosimone added the 2020-02-meeting To discuss during 2020-02-meeting label Feb 4, 2020
@bassosimone bassosimone self-assigned this Feb 4, 2020
bassosimone pushed a commit that referenced this issue Feb 10, 2020
@darkk @bassosimone
ndt7: start improving ping implementation
2c32a60 
This diff has been written by @darkk as part of #234 and
has been extracted #234 by @bassosimone, with the objective
of merging these low hanging fruits while we look into the
proper way of implementing the `/ping` endpoint.

Closes #242
@bassosimone bassosimone linked a pull request Feb 10, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
2020-02-meeting To discuss during 2020-02-meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ndt7: start improving ping implementation m-lab/ndt-server
2 participants
@bassosimone @mehtab11