Fix import path behaviour when using full path #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
fix-import-path-behaviour
branch
from
0219938
to
44d3cd5
Compare
|
Can we make this as an additive test (without modifying any of the existing ones)? The tests listed here were meant to catch regressions in the handling of the go_package and plugin param interactions. The package one there specifically was catching reserved keywords as well. |
This change makes protoc-gen-star conform to the behaviour of protoc-gen-go in the presence of an import_path parameter that contains slashes. See https://github.com/golang/protobuf/blob/v1.4.2/protoc-gen-go/generator/generator.go#L637-L643 for evidence of this behaviour in protoc-gen-go. Fixes lyft#77
johanbrandhorst
force-pushed
the
fix-import-path-behaviour
branch
from
44d3cd5
to
9a8e34b
Compare
Done |
|
Closing this since it is obsolete given we migrated to protobuf APIv2, which deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
protoc-gen-starconform to the behaviour ofprotoc-gen-goin the presence of animport_pathparameter that contains slashes.See https://github.com/golang/protobuf/blob/v1.4.2/protoc-gen-go/generator/generator.go#L637-L643
for evidence of this behaviour in
protoc-gen-go.Fixes #77