Skip to content

Commit 5e80499

Browse files
Migrate to networking.k8s.io v1
1 parent 4356402 commit 5e80499

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

pkg/controller/flink/ingress.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"github.com/lyft/flinkk8soperator/pkg/controller/common"
99
"github.com/lyft/flinkk8soperator/pkg/controller/config"
1010
"github.com/lyft/flinkk8soperator/pkg/controller/k8"
11-
"k8s.io/api/networking/v1beta1"
11+
v1network "k8s.io/api/networking/v1"
1212
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1313
"k8s.io/apimachinery/pkg/util/intstr"
1414
)
@@ -25,7 +25,7 @@ func GetFlinkUIIngressURL(jobName string) string {
2525
return ReplaceJobURL(config.GetConfig().FlinkIngressURLFormat, jobName)
2626
}
2727

28-
func FetchJobManagerIngressCreateObj(app *flinkapp.FlinkApplication) *v1beta1.Ingress {
28+
func FetchJobManagerIngressCreateObj(app *flinkapp.FlinkApplication) *v1network.Ingress {
2929
podLabels := common.DuplicateMap(app.Labels)
3030
podLabels = common.CopyMap(podLabels, k8.GetAppLabel(app.Name))
3131

@@ -38,30 +38,30 @@ func FetchJobManagerIngressCreateObj(app *flinkapp.FlinkApplication) *v1beta1.In
3838
},
3939
}
4040

41-
backend := v1beta1.IngressBackend{
41+
backend := v1network.IngressBackend{
4242
ServiceName: getJobManagerServiceName(app),
4343
ServicePort: intstr.IntOrString{
4444
Type: intstr.Int,
4545
IntVal: getUIPort(app),
4646
},
4747
}
4848

49-
ingressSpec := v1beta1.IngressSpec{
50-
Rules: []v1beta1.IngressRule{{
49+
ingressSpec := v1network.IngressSpec{
50+
Rules: []v1network.IngressRule{{
5151
Host: GetFlinkUIIngressURL(getIngressName(app)),
52-
IngressRuleValue: v1beta1.IngressRuleValue{
53-
HTTP: &v1beta1.HTTPIngressRuleValue{
54-
Paths: []v1beta1.HTTPIngressPath{{
52+
IngressRuleValue: v1network.IngressRuleValue{
53+
HTTP: &v1network.HTTPIngressRuleValue{
54+
Paths: []v1network.HTTPIngressPath{{
5555
Backend: backend,
5656
}},
5757
},
5858
},
5959
}},
6060
}
61-
return &v1beta1.Ingress{
61+
return &v1network.Ingress{
6262
ObjectMeta: ingressMeta,
6363
TypeMeta: v1.TypeMeta{
64-
APIVersion: v1beta1.SchemeGroupVersion.String(),
64+
APIVersion: v1network.SchemeGroupVersion.String(),
6565
Kind: k8.Ingress,
6666
},
6767
Spec: ingressSpec,

pkg/controller/flink/job_manager_controller_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"github.com/stretchr/testify/assert"
2121
v1 "k8s.io/api/apps/v1"
2222
coreV1 "k8s.io/api/core/v1"
23-
"k8s.io/api/networking/v1beta1"
23+
v1network "k8s.io/api/networking/v1"
2424
k8sErrors "k8s.io/apimachinery/pkg/api/errors"
2525
"k8s.io/apimachinery/pkg/runtime"
2626
"k8s.io/apimachinery/pkg/runtime/schema"
@@ -132,7 +132,7 @@ func TestJobManagerCreateSuccess(t *testing.T) {
132132
labels := map[string]string{
133133
"flink-app": "app-name",
134134
}
135-
ingress := object.(*v1beta1.Ingress)
135+
ingress := object.(*v1network.Ingress)
136136
assert.Equal(t, app.Name, ingress.Name)
137137
assert.Equal(t, app.Namespace, ingress.Namespace)
138138
assert.Equal(t, labels, ingress.Labels)
@@ -215,7 +215,7 @@ func TestJobManagerHACreateSuccess(t *testing.T) {
215215
labels := map[string]string{
216216
"flink-app": "app-name",
217217
}
218-
ingress := object.(*v1beta1.Ingress)
218+
ingress := object.(*v1network.Ingress)
219219
assert.Equal(t, app.Name, ingress.Name)
220220
assert.Equal(t, app.Namespace, ingress.Namespace)
221221
assert.Equal(t, labels, ingress.Labels)
@@ -430,7 +430,7 @@ func TestJobManagerCreateSuccessWithVersion(t *testing.T) {
430430
labels := map[string]string{
431431
"flink-app": "app-name",
432432
}
433-
ingress := object.(*v1beta1.Ingress)
433+
ingress := object.(*v1network.Ingress)
434434
assert.Equal(t, app.Name+"-"+testVersion, ingress.Name)
435435
assert.Equal(t, app.Namespace, ingress.Namespace)
436436
assert.Equal(t, labels, ingress.Labels)

0 commit comments

Comments
 (0)