Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated migrations fail if custom configurations are present #1497

Open
jeffherald opened this issue Jun 10, 2021 · 0 comments
Open

Federated migrations fail if custom configurations are present #1497

jeffherald opened this issue Jun 10, 2021 · 0 comments
Labels
type: bug Something isn't working

Comments

@jeffherald
Copy link
Contributor

Description
An error is thrown when running federated migrations according to the docs if any additional configuration has been added to the config:
{"level":"fatal","ts":1623325336.0228286,"caller":"gateway/config.go:53","msg":"parsing configuration failed","file":"../../clutch-config.yaml","error":"proto: (line 1:624): unable to resolve \"types.google.com/foo.bar.v1.Config\": \"not found\""}

To work around this, i copied the migrations folder into my gateway and added a dummy.go with all of my config packages imported with the blank identifier.

I think a better solution would be to refactor the migration code into a package that can be imported to custom gateways and adopt something like cobra and implement migrations as a sub command.

Expected Behavior
Federated migrations work when additional configurations are present

Actual Behavior
See above.

Version
d744413

Other Context

@jeffherald jeffherald added the type: bug Something isn't working label Jun 10, 2021
@github-actions github-actions bot added the stale Issue hasn't had activity in awhile label Jul 19, 2021
@danielhochman danielhochman reopened this Jul 23, 2021
@danielhochman danielhochman removed the stale Issue hasn't had activity in awhile label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants