Skip to content

Commit 432ac81

Browse files
authored
attrib.get should have same overload signature as _element.get (GH-97)
1 parent ab0f6ab commit 432ac81

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

lxml-stubs/etree.pyi

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,10 @@ class _Attrib:
322322
def __getitem__(self, key: _AnyStr) -> _AnyStr: ...
323323
def __bool__(self) -> bool: ...
324324
def __len__(self) -> int: ...
325-
def get(self, key: _AnyStr, default: _AnyStr = ...) -> Optional[_AnyStr]: ...
325+
@overload
326+
def get(self, key: _TagName) -> Optional[str]: ...
327+
@overload
328+
def get(self, key: _TagName, default: _T) -> Union[str, _T]: ...
326329
def keys(self) -> _ListAnyStr: ...
327330
def __iter__(self) -> Iterator[_AnyStr]: ... # actually _AttribIterator
328331
def iterkeys(self) -> Iterator[_AnyStr]: ...

0 commit comments

Comments
 (0)