Allow overriding RUNTIME_DIR with a cli flag #2 #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… startup What was RUNTIME_PATH is now named DEFAULT_RUNTIME_PATH so this should not change current behavior. It is done in preparation for adding a flag to override the runtime path on startup. Signed-off-by: Sebastien Dabdoub <[email protected]> - permission mask change 0755 -> 0700 - commit message edits - use tabs everywhere instead of spaces Signed-off-by: Alexander Mikhalitsyn <[email protected]>
Adds a --runtime-dir cli flag which overrides the /run dir in the lxcfslib. This ended up being kind of tricky because of how lxcfslib can be reloaded and its use of a library constructor. In order read the cli flag and then set a variable in the library, I removed the contstructor and made init happen as part of the fuse load/reload. I also added the runtime field to the lxcfs_opts struct and upped its version for backwards compatibility. Signed-off-by: Sebastien Dabdoub <[email protected]> - permission mask change 0755 -> 0700 - prevent potential NULL-pointer dereference in lxcfs_fuse_init() - commit message edits - one commit was squashed Signed-off-by: Alexander Mikhalitsyn <[email protected]>
|
cc @sdab |
stgraber
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just an updated version of #621
Unfortunately, I wasn't able to update the original branch for some reason GitHub just automatically closed a PR after I force-pushed my edits into the original PR branch.