Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adjustment easier - Input box contains values of properties #864

Closed
jukrb0x opened this issue Mar 9, 2021 · 5 comments
Closed

Make adjustment easier - Input box contains values of properties #864

jukrb0x opened this issue Mar 9, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@jukrb0x
Copy link

jukrb0x commented Mar 9, 2021

Is your feature suggestion related to a problem? Please describe.
When adjusting values for appearance, it's hard to control the value bar for a precise adjustment.

image

Describe the solution you'd like
The right side indicates the value of properties, which can be made in an input box that contains particular values.

Describe alternatives you've considered
N/A

@jukrb0x jukrb0x added the enhancement New feature or request label Mar 9, 2021
@lwouis
Copy link
Owner

lwouis commented Mar 9, 2021

Hi @jukrb0x!

The advantage or sliders is that is constraints possible values. With a text box, users could enter wrong values such as letters or number too high/low. It also gives context. For instance setting the bar in the middle shows me that my choice is actually in the middle visually.

If you find it hard to handle precisely with the mouse, i think it's also possible to use the arrow keys to move one tick at a time.

Does that do it for you?

@jukrb0x
Copy link
Author

jukrb0x commented Mar 9, 2021

Thanks @lwouis for responding!

User can type in a wrong way such as letters or negative values, but the text box can do a test with input values right? Say if user input is not in the range of valid data then it will not be accepted by the text box.

I totally agree the visually sliders would help to understand a lot, what I mean is, we can keep the setting slider, but the values at the right hand side of the slider, can be made in a text box contains the value of property controlled by the slider. That is, user can type a precise value (validity should be tested when typing) and also can slide the setting bar for choosing a proper position.

Also, I've tried the arrow keys to handle data and it doesn't work for me, I clicked the circle of slider and press the arrow keys. can u please elaborate how to do it.

@jukrb0x
Copy link
Author

jukrb0x commented Mar 9, 2021

Thanks @lwouis for responding!

User can type in a wrong way such as letters or negative values, but the text box can do a test with input values right? Say if user input is not in the range of valid data then it will not be accepted by the text box.

I totally agree the visually sliders would help to understand a lot, what I mean is, we can keep the setting slider, but the values at the right hand side of the slider, can be made in a text box contains the value of property controlled by the slider. That is, user can type a precise value (validity should be tested when typing) and also can slide the setting bar for choosing a proper position.

Also, I've tried the arrow keys to handle data and it doesn't work for me, I clicked the circle of slider and press the arrow keys. can u please elaborate how to do it.

For instance, I took a design software as an example, the property Width can be adjusted as the slider bar changes or the value in the text box changes, these two indicate the same.

image

@lwouis
Copy link
Owner

lwouis commented Mar 9, 2021

Also, I've tried the arrow keys to handle data and it doesn't work for me, I clicked the circle of slider and press the arrow keys. can u please elaborate how to do it.

It used to be possible to navigate the preferences with keyboard (tab key) and select the sliders that way then arrow left/right, then tab to the next slider, etc. I tried right now and it didn't work in any tab of the preference window. Something is broken. I opened a ticket to fix this.

Regarding your UI suggestion, I understand it's possible, but I know from having seen an implementation of such thing that's it's a rat nest of edge-cases, and back when I implemented the preferences, I thought a slider would avoid that. Just for fun here are some example use cases to cover. We need prevent the user from inputing in the box:

  • Letters (people trying to type one instead of 1, or 12px instead of 12)
  • Special characters (including spaces, like typing 12 or 12 for example, or decimals like 1.5)
  • Emojis
  • Non-English characters
  • Handle numbers of other languages (I live in Japan where people would type 123 instead of 123)
  • Handle zero-leading notation like 01 instead of 1
  • Handling numbers too big and too small (user types 100000. Should we block them from typing after the first 0, or should we let them type it wrong but then have a red rectangle around the box?)
  • The list goes on

@lwouis
Copy link
Owner

lwouis commented May 28, 2022

Closing this as subsumed by #351

@lwouis lwouis closed this as completed May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants