Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class based global logger #2

Open
lvntky opened this issue Jun 19, 2024 · 3 comments
Open

Class based global logger #2

lvntky opened this issue Jun 19, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lvntky
Copy link
Owner

lvntky commented Jun 19, 2024

Im using spdlog for logger, ive already created a log.cpp file that configures the global logger. Need to add this logger to the classfile.cpp

@lvntky lvntky added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 19, 2024
@jbytecode
Copy link

Although it is not really related to the issue here but I want to express my thoughts.

Great project, good luck! I'am daily pulling the latest changes and waiting to run my Hello.class to get work!

I also added the magic int add(int x, int y) method to end up with the working example.

The code is also educative for those who want to learn internals of a JVM just becacuse the others are too big to follow up what is going on there.

Thank you for your work!

@lvntky
Copy link
Owner Author

lvntky commented Jun 23, 2024

Hello Profesor @jbytecode ! I am actually more than happy to see such comment like a scientist like you. Now, with the latest changes we are able to run AddMain.java but i think i need to implement method invocation mechanism to run Hello.class. This was a one weekend project actually but i can implement more if there is a change/feature request. I will be honored if this one could be use in a educational tool for students (event its written quite sloppy 😁).

Ps: Sir, if you change the log level on log.hpp and take it to the debug level you can see a more detailed logs that shows actually whats going on.

@jbytecode
Copy link

CVM successfully terminated program: sample/AddMain.class with return value : 29

Nice, good luck again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants