Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: "Opts" includes empty "--range" parameter #107

Closed
neuschaefer opened this issue Mar 26, 2024 · 4 comments · Fixed by #109
Closed

web: "Opts" includes empty "--range" parameter #107

neuschaefer opened this issue Mar 26, 2024 · 4 comments · Fixed by #109

Comments

@neuschaefer
Copy link
Contributor

I just noticed a bug in my code (#106): The --range parameter is emitted even when there are no ranges.

Opts: ...  --range  --format lvgl -o font.c
@neuschaefer neuschaefer changed the title "Opts" includes empty "--range" parameter web: "Opts" includes empty "--range" parameter Mar 26, 2024
@kisvegabor
Copy link
Member

Can you send a PR to fix it?

@neuschaefer
Copy link
Contributor Author

I'll give it a try over the weekend

@sunzigang
Copy link
Contributor

I had the same problem, this commit might fix the bug . #108

@neuschaefer
Copy link
Contributor Author

neuschaefer commented Mar 29, 2024 •
edited
Loading

I had the same problem, this commit might fix the bug . #108

Your PR looks good, but it doesn't seem to fix this particular issue: The converter still emits an empty --ranges option.

I'll make a PR.

neuschaefer added a commit to neuschaefer/lv_font_conv that referenced this issue Mar 29, 2024
@neuschaefer
Don't emit empty '--ranges' option
34a4f97 
Fixes: lvgl#107
neuschaefer added a commit to neuschaefer/lv_font_conv that referenced this issue Mar 29, 2024
@neuschaefer
Don't emit empty '--ranges' option
4090613 
Fixes: lvgl#107
neuschaefer added a commit to neuschaefer/lv_font_conv that referenced this issue Mar 29, 2024
@neuschaefer
Don't emit empty '--ranges' option
452c514 
Fixes: lvgl#107
@neuschaefer neuschaefer mentioned this issue Mar 29, 2024
Merged
neuschaefer added a commit to neuschaefer/lv_font_conv that referenced this issue Mar 29, 2024
@neuschaefer
Don't emit empty '--ranges' option
472e4ae 
Fixes: lvgl#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't emit empty '--ranges' option neuschaefer/lv_font_conv
3 participants
@neuschaefer @kisvegabor @sunzigang