Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Humble ros_bridge does spatial detection missing fields #542

Open
kikass13 opened this issue Jun 8, 2024 · 3 comments
Open

[BUG] Humble ros_bridge does spatial detection missing fields #542

kikass13 opened this issue Jun 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@kikass13
Copy link

kikass13 commented Jun 8, 2024

Describe the bug
Humble implementation of the ros msg converter does not provide a score value for spatial detections

Expected behavior
The score value should be set into the ros msg

Additional context
CLICK ME - The Line in code where the fix should be added

something like this should be added in the IS_HUMBLE ifdef

opDetectionMsg.detections[i].results[0].score = inNetData->detections[i].confidence;

which results in a ros2 topic echo like this:

header:
  stamp:
    sec: 1717864050
    nanosec: 427740811
  frame_id: oak_rgb_camera_optical_frame
detections:
- results:
  - class_id: '0'
    score: 8.31591796875
  bbox:
    center:
      position:
        x: 78.0
        y: 250.0
      theta: 0.0
    size_x: 200.0
    size_y: 252.0
  position:
    x: -0.19737829267978668
    y: -0.07760991901159286
    z: 0.5516734719276428
  is_tracking: false
  tracking_id: ''
---
@kikass13 kikass13 added the bug Something isn't working label Jun 8, 2024
@sagarvl96
Copy link

Any idea on how to publish the score in the meantime?

@Serafadam
Copy link
Collaborator

Hi, thanks for the report, the fix is available here and will be merged soon

@sagarvl96
Copy link

Hello @Serafadam!
Was the fix merged to the humble branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants