[WRONG BRANCH] fix(cli): bind status probe token to hub snapshot - #498
[WRONG BRANCH] fix(cli): bind status probe token to hub snapshot#498luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Closing this original proposal because its useful scope has been reimplemented as a focused, independently validated submission. Further review and CI follow-up now belong to that active submission; this does not claim the change is merged. |
Motivation
service-api-tokenindependently of the snapshotted client connection, which could cause a mismatched or newly rotated token to be sent to a different hub origin and disclose a bearer credential.Description
collectRemoteHubStatusnow reads the live connection (readClientConnectionState()) and verifies the token fingerprint matches the snapshotted connection before passing a token toresolveHubState().fetchis not invoked in those cases.src/cli/status.tsandtests/cli/cli-status-hub-state.test.ts.Testing
./node_modules/.bin/bun test tests/cli/cli-status-hub-state.test.tsand it passed (new tests included)../node_modules/.bin/bun run typecheckand./node_modules/.bin/bun run privacy:scanand both succeeded../node_modules/.bin/bun run test) encountered environment-sensitive worker panics and unrelated Codex shim cleanup failures during parallel runs; the focused tests, typecheck, and privacy scan (the relevant, focused validations for this change) passed.Codex Task