Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIR support #1044

Open
lutzroeder opened this issue Feb 7, 2023 · 8 comments
Open

MLIR support #1044

lutzroeder opened this issue Feb 7, 2023 · 8 comments

Comments

@tucan9389
Copy link

tucan9389 commented Apr 23, 2023

@lutzroeder
First of all, thanks for your issue. And thanks for the repo as a person who has used this tool for almost 4 years.

And I'm personally interested in this issue.

Would you happen to have any good references to make some progress on this?
I'm trying to understand the overall code structure and the detailed implementation (especially for tflite and coreml), but it's pretty hard to understand at once. Would you give some guides or tips? I think that good reference commits might be helpful for understanding the things that I should implement.

lutzroeder added a commit that referenced this issue Apr 23, 2023
@lutzroeder
Copy link
Owner Author

lutzroeder commented Apr 23, 2023

Initially, writing a JavaScript parser for MLIR to tokenize the file and extract the module structure. onnx.Reader.text as a starting point of what such code looks like for a similar text format.

There is already a mlir.ModelFactory which gets invoked when dragging an .mlir file into a view. The rest of the work is about mapping the parsed MLIR module into the object model the viewer consumes. CONTRIBUTING.md has steps to launch a debugger. node ./test/models.js mlir to run the existing test files.

This was referenced Apr 29, 2023
@tucan9389
Copy link

tucan9389 commented May 4, 2023

@lutzroeder
Gently reminder. Could you review #1088?

And I'm planning quite a big update for testing with the .mlir files on Github and reinforcement of the mlir.Tokenizer and mlir.Parser based on the #1088. If you think we should have a #1088 review first and move forward, please tell me ASAP.

Thanks :)

@lutzroeder
Copy link
Owner Author

lutzroeder commented May 4, 2023

@tucan9389 continue iterating on the pull request. Let's review once it is in good shape to move towards adding it to a release.

@tucan9389
Copy link

@lutzroeder
Oh, I see. The MLIR parser can be a massive complex. Before it gets too big, I thought we could merge or get some reviews. I'm not sure if this contribution adds value to this repository.

Do you happen to have a useful guide for releasing this feature or any test cases to merge into the main branch?

I would prefer to get reviews in between rather than getting big reviews at once, but if it's difficult for you now, could you please let me know the minimum requirements for merging? I wonder if you have thought about the work unit to merge.

@tucan9389
Copy link

tucan9389 commented May 7, 2023

@lutzroeder
Hi, I made some additional progress.
Please check tucan9389#1 out.

I think this can be merged into the main repo. Can you review and pull my implementation?
If you think there are remaining works, please let me know.

This is my side project, so the next progress could take some time.

Anyway, thanks for your comment and advice :)

@tucan9389
Copy link

tucan9389 commented Oct 8, 2023

@lutzroeder
Hi, I found that my previous implementation (to parse a text MLIR file in js level) was not a good way to achieve sustainability.
I'm looking for a more proper way to use WebAssembly in netron to use MLIR parser directly. This can make parse MLIR graphs with ease and with less error. I'll comment if I make some progress.

Here the keywords are that I'm looking at:

  • WebAssembly
  • Emscripten (emcc command to generate *.wsam file)
  • mlir/Parser.h
  • How to deploy it in netron environment
  • etc.

@lutzroeder
Copy link
Owner Author

lutzroeder commented Oct 8, 2023

@tucan9389 do you have some additional context what you mean by "achive sustainability"? The goal is to avoid dependencies, run in many environments and support a unified debugging experience. Improving the JavaScript parser implementation seems the right path to get there.

lutzroeder added a commit that referenced this issue Jan 28, 2024
lutzroeder added a commit that referenced this issue Jun 2, 2024
@lutzroeder lutzroeder closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2024
@lutzroeder lutzroeder reopened this Sep 28, 2024
lutzroeder added a commit that referenced this issue Sep 28, 2024
lutzroeder added a commit that referenced this issue Sep 29, 2024
lutzroeder added a commit that referenced this issue Sep 29, 2024
lutzroeder added a commit that referenced this issue Oct 1, 2024
lutzroeder added a commit that referenced this issue Oct 5, 2024
lutzroeder added a commit that referenced this issue Nov 2, 2024
lutzroeder added a commit that referenced this issue Nov 6, 2024
lutzroeder added a commit that referenced this issue Nov 15, 2024
lutzroeder added a commit that referenced this issue Nov 17, 2024
lutzroeder added a commit that referenced this issue Nov 17, 2024
lutzroeder added a commit that referenced this issue Nov 18, 2024
lutzroeder added a commit that referenced this issue Nov 22, 2024
lutzroeder added a commit that referenced this issue Nov 22, 2024
lutzroeder added a commit that referenced this issue Nov 23, 2024
lutzroeder added a commit that referenced this issue Nov 24, 2024
lutzroeder added a commit that referenced this issue Nov 25, 2024
lutzroeder added a commit that referenced this issue Nov 25, 2024
lutzroeder added a commit that referenced this issue Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants