feat: various improvements #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favna
force-pushed
the
feat/various-improvements
branch
2 times, most recently
from
f66307e to
5f9b8a9
Compare
|
Note: this would also fix #31, as rollup is producing ESM output. |
Nytelife26
suggested changes
Apr 3, 2021
- Changed from Travis to Github Actions - Improved the TLD auto update script (with regards to Skyra Project) - Added dependabot config for updating github actions - Moved source file to src directory - Replaced uglifyjs + browserify with rollup, which does all of this, plus better (through Terser) - Changed from npmignore to files array in package.json
favna
force-pushed
the
feat/various-improvements
branch
from
4126259 to
37190e6
Compare
|
Bump @lupomontero |
|
@lupomontero it would be great if you could merge these changes, thanks in advance 👍 |
|
Closing this because repo owner completely ignored this PR and caused many conflicts in the branch that I do not feel like fixing as we have also moved on from using psl in our project. A true shame considering the amount of issues this was set to fix but I guess @lupomontero just doesn't care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces various improvements that should make things for this package better.
Important Note: Due to the way that GitHub actions work you'll have to add a secret with is a Personal Access Token to create the automatic PRs with in the future.
You can see how to create a PAT here: https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token.
Then once you have that add it to repo secrets as described here: https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository
The secret should be named
CI_TOKENfixes #31
fixes #249
resolves #5