Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lune setup to respect Luau LSP v1.36 #282

Open
CompeyDev opened this issue Dec 7, 2024 · 1 comment
Open

Update lune setup to respect Luau LSP v1.36 #282

CompeyDev opened this issue Dec 7, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CompeyDev
Copy link
Contributor

In Luau LSP v1.36, the luau-lsp.require.directoryAliases configuration was deprecated in favor of using aliases defined in the .luaurc file. Lune should be updated to respect this new configuration method.

However, transitioning to .luaurc poses a challenge since users who are still on earlier versions of Luau LSP will lose autocomplete functionality if we implement this change. A potential solutions would involve us determining the version of Luau LSP that is currently in use, or introducing a flag which allows users to explicitly specify if they want editor settings instead of a .luaurc change.

@filiptibell filiptibell added enhancement New feature or request good first issue Good for newcomers labels Dec 18, 2024
@filiptibell
Copy link
Collaborator

However, transitioning to .luaurc poses a challenge since users who are still on earlier versions of Luau LSP will lose autocomplete functionality if we implement this change. A potential solutions would involve us determining the version of Luau LSP that is currently in use, or introducing a flag which allows users to explicitly specify if they want editor settings instead of a .luaurc change.

This seems like a non-issue to me, we should be fine to just make the change to use .luaurc without adding additional complexity to the command. People using Luau LSP most likely use an editor that auto-updates extensions (VSCode), so if they're on an older version it's because they have already messed with their editor config to disable auto update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants