Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build error when "./absolute webpack" intermittently #526

Open
nadongguri opened this issue Nov 13, 2017 · 4 comments
Open

Fix the build error when "./absolute webpack" intermittently #526

nadongguri opened this issue Nov 13, 2017 · 4 comments

Comments

@nadongguri
Copy link
Collaborator

If you run "./absolute webpack" many times, you would see the error comming

$ ./absolute webpack
[14:04:32] Requiring external module ts-node/register
[14:04:32] Using gulpfile /absolute/gulpfile.ts
[14:04:32] Starting 'webpack'...
ts-loader: Using [email protected] and /absolute/tsconfig.json

stream.js:74
throw er; // Unhandled stream error in pipe.
^
Error: absolute/node_modules/@types/supertest/index.d.ts
(27,20): error TS2304: Cannot find name 'RegExp' /absolute/node_modules/@types/supertest/index.d.ts

....

I think this error is due to the line in push_service_worker.ts.

/// <reference path="../../node_modules/typescript/lib/lib.webworker.d.ts"/>

When I removed that line or modifying from /// to // made no command error.
I'm not sure why that leads to the build error but if owners can agree of my experimental test,
I will upload the patch.

@nadongguri
Copy link
Collaborator Author

@haeungun, is that line is really required?

@haeungun
Copy link
Contributor

If that causes an error, you can delete it.
We can load an interface without a reference tag.

@nadongguri
Copy link
Collaborator Author

@haeungun, thanks to your reply.
@GarlicB, you were checking this issue at MOGACKO, would you fix this issue ASAP? I can't make PR in the company.

@GarlicB
Copy link
Contributor

GarlicB commented Nov 13, 2017

@nadongguri OK. soon i'll make PR about that.

romandev pushed a commit that referenced this issue Nov 13, 2017
Remove the reference tag in push_service_worker.ts.
It makes some trouble when running webpack to build.

ISSUE=#526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants