More symbols

[lunaroyster]

It's simple. Let's add more symbols.

Here's a good place to start: https://oeis.org/wiki/List_of_LaTeX_mathematical_symbols

Here are symbols requests by users: https://airtable.com/shrwk7aGIsiDIDwAe/tblX2jFkbt0J1f88F

I'd begin with symbols in more common use by beginners

[isa3bel]

Hi, I added a tax symbol. I am new to open source, so let me know if this was done correctly. I created a PR. Also, how do I test my changes locally on my machine? Thanks!

[lunaroyster]

Thanks @isa3bel!

To run the project, take a look at this: https://github.com/lunaroyster/LaTeX-search/blob/master/react-readme.md

[isa3bel]

I think I created a PR for a branch called tax. Was it removed?

[lunaroyster]

It looked good, so I merged your PR. Here: #3

Again, thanks for contributing!

[isa3bel]

are there a list of symbols that still need to be added? I can add some more and create a PR

[isa3bel]

also, since you changed master, how do I get the latest on my local machine? if I do git pull it says I have the latest even though I don't since you changed a bit of wording from my PR

[lunaroyster]

@isa3bel I updated the first comment to include a list.

You need to merge the upstream repo. Here are some resources:

https://help.github.com/en/articles/merging-an-upstream-repository-into-your-fork

https://help.github.com/en/articles/getting-changes-from-a-remote-repository#fetching-changes-from-a-remote-repository

Edit: I'd also recommend working with a GUI client like desktop.github.com or gitkraken.com

[isa3bel]

git fetch https://github.com/lunaroyster/LaTeX-search master

I used this command but my local was still not updated.

[lunaroyster]

try git pull https://github.com/lunaroyster/LaTeX-search master.

fetch only downloads the changes, while pull also merges them

[isa3bel]

got it thanks!

So I got the latest changes, committed, and then pushed. Did I push to the forked repo rather than directly to your master? I just pushed, but didn't sent out a PR, since that's unnecessary.

[lunaroyster]

It looks like you merged commits from the remote, and pushed to your fork.

[isa3bel]

I get these strange errors if I try to run the program on my local machine:

react-scripts start

sh: react-scripts: command not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR! [email protected] start: react-scripts start
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the [email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/isabelbolger/.npm/_logs/2019-10-05T03_34_37_550Z-debug.log

do you know what the error could be?

[lunaroyster]

I think you can try prefixing those commands with npx? That indicates you're referring to a package locally installed in latex-search (rather than globally installed). Lemme know if this works.