Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDE error evaluated on bc points in PDE.losses but not used by following codes #1756

Open
mynanshan opened this issue May 27, 2024 · 1 comment
Open

PDE error evaluated on bc points in PDE.losses but not used by following codes #1756

mynanshan opened this issue May 27, 2024 · 1 comment

Comments

@mynanshan
Copy link

deepxde/deepxde/data/pde.py

Line 168 in 10ec4e5

error_f = [fi[bcs_start[-1] :] for fi in f]

I am just wondering why the PDE loss f is computed on the full input array while its f[:bcs_start[-1]] part is not used. Should it be optimized by just passing the part of the inputs to PDE.losses?
@mynanshan mynanshan reopened this May 28, 2024
@lululxvi
Copy link
Owner

PDE error are evaluated at all points including boundary points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lululxvi @mynanshan