Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recreate curl request could be a bug with virtualmin that needs to be reported, ... #26

Open
todo bot opened this issue Jun 14, 2020 · 2 comments
Assignees

Comments

@todo
Copy link

todo bot commented Jun 14, 2020

// todo recreate curl request could be a bug with virtualmin that needs to be reported, currently after a script install virtualmin returns a 500 status will check with other virtualmin install
$type = strtolower($postRequest['script_name']);
$prams = [
"domain" => $service_fields->virtualmin_domain,
"type" => $type,
"version" => $postRequest['script_version'],


This issue was generated by todo based on a todo comment in 4656ce4 when #24 was merged. cc @lukesUbuntu.
@todo todo bot added the todo 🗒️ label Jun 14, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug label Jun 14, 2020
@lukesUbuntu
Copy link
Owner

lukesUbuntu commented Jun 15, 2020

based on this thread https://www.virtualmin.com/comment/811540#comment-811540
using --multiline on curl request causes overhead.
Will do some bench testing on creating scripts via dedicated and vps server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant