Skip to content

Commit a7736b8

Browse files
authored
Merge pull request #185 from jooola/private_attrs
fix: API object/method attributes are private
2 parents 59e283f + f478cb6 commit a7736b8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pyzabbix/__init__.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,25 +268,25 @@ def __getitem__(self, attr: str) -> "ZabbixAPIObject":
268268
# pylint: disable=too-few-public-methods
269269
class ZabbixAPIMethod:
270270
def __init__(self, method: str, parent: ZabbixAPI):
271-
self.method = method
272-
self.parent = parent
271+
self._method = method
272+
self._parent = parent
273273

274274
def __call__(self, *args, **kwargs):
275275
if args and kwargs:
276276
raise TypeError("Found both args and kwargs")
277277

278-
return self.parent.do_request(self.method, args or kwargs)["result"]
278+
return self._parent.do_request(self._method, args or kwargs)["result"]
279279

280280

281281
# pylint: disable=too-few-public-methods
282282
class ZabbixAPIObject:
283283
def __init__(self, name: str, parent: ZabbixAPI):
284-
self.name = name
285-
self.parent = parent
284+
self._name = name
285+
self._parent = parent
286286

287287
def _method(self, attr: str) -> ZabbixAPIMethod:
288288
"""Dynamically create a method (ie: get)"""
289-
return ZabbixAPIMethod(f"{self.name}.{attr}", self.parent)
289+
return ZabbixAPIMethod(f"{self._name}.{attr}", self._parent)
290290

291291
def __getattr__(self, attr: str) -> ZabbixAPIMethod:
292292
return self._method(attr)

0 commit comments

Comments
 (0)