Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tools with unknown domain / url format #44

Open
jvineveld opened this issue Dec 4, 2020 · 2 comments
Open

Adding tools with unknown domain / url format #44

jvineveld opened this issue Dec 4, 2020 · 2 comments

Comments

@jvineveld
Copy link

Hello,

Great extension! I would like to add SiteSpect to the list of tools, but I'm running into an issue with the configuration.
Currently, the tools are recognized by their domain names.

But for SiteSpect, many customers run on-premise, with custom (sub)domains.

Would it be possible to add a feature like this:
When clicking on the extension icon, in the dropdown we could create a way to 'force' an SRM check of a specific tool, on the current page.

In this case, it won't do it automatically, but there is a possibility to verify the SRM. Also after manually triggering, for that user we could store the current domain as being that "tool" so it could automatically try to do it in the future.

Would like to hear your thoughts about this.

Kind regards,
Jonas

@lukasvermeer
Copy link
Owner

Hello!

Great to hear you want to contribute! That's awesome!

I am not familiar with SiteSpect, so I was not aware of the custom domains thing. We will need to figure out how to configure the Chrome Extension so that this is possible. Currently, the permitted domains are hardcoded in the manifest. I think we will need additional (scary looking) permissions from the user in order to support arbitrary domains, but perhaps there is a way for users to add domains to this list manually?

@lukasvermeer
Copy link
Owner

I think it looks like users can change which domains an extension has access to, but only if the extension is first configured to request permissions to access all domains.

Can you try change the manifest based on this guide to see if that works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants