Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with multiple times the same scope when disabling the mode options #324

Closed
lukasoppermann opened this issue Jan 15, 2025 · 2 comments · Fixed by #325
Closed

Bug with multiple times the same scope when disabling the mode options #324

lukasoppermann opened this issue Jan 15, 2025 · 2 comments · Fixed by #325
Assignees
@0m4r
Labels
bug Something isn't working

Comments

@lukasoppermann
Copy link
Owner

When those settings are disabled:
Image

I get the scope added a lot of times:

Image

Update
I tested and it seems to be related to the first option Add mode to design token name (if 2 or more modes).

If this is off, the scope gets added many times, if it is on, everything is fine.
@lukasoppermann lukasoppermann added the bug Something isn't working label Jan 15, 2025
@0m4r 0m4r mentioned this issue Jan 17, 2025
Merged
@0m4r
Copy link
Collaborator

0m4r commented Jan 17, 2025

@lukasoppermann this has been fixed in #325

@lukasoppermann
Copy link
Owner Author

This was quick, thank you. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0m4r 0m4r

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: deepMerge | remove duplicates when merging arrays 0m4r/design-tokens-324
2 participants
@0m4r @lukasoppermann