Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of Tracking ID #13

Open
amenk opened this issue Jun 18, 2015 · 0 comments
Open

Validation of Tracking ID #13

amenk opened this issue Jun 18, 2015 · 0 comments
Assignees
@tux-rampage
Labels
enhancement
Milestone
1.0.3

Comments

@amenk
Copy link

amenk commented Jun 18, 2015

If I enter "Tracking ID" for the tracking ID, \LUKA_GoogleAdWords_Block_Conversion::getFallbackUrl crashes because the URL contains spaces (Invalid URI supplied in $uri = Zend_Uri::factory($url); ). So the tracking ID should be validated and/or escaped in the URL.
@tux-rampage tux-rampage self-assigned this Jun 24, 2015
@tux-rampage tux-rampage added this to the 1.0.3 milestone Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tux-rampage tux-rampage

Labels
enhancement
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
2 participants
@tux-rampage @amenk