Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing action name #12

Open
hungpvdev opened this issue Jun 8, 2015 · 0 comments
Open

Comparing action name #12

hungpvdev opened this issue Jun 8, 2015 · 0 comments
Assignees
Milestone

Comments

@hungpvdev
Copy link

Thanks for create this extension. It 's useful and help me save time in customer request. I found an error make me can't load google script using "Use Custom Action Name".
This value should be trim() before compare with FullActionName.

Please update app/code/community/LUKA/GoogleAdWords/Model/Conversion.php
line 42
$match = ($this->getAction() == $actionName);
-> $match = (trim($this->getAction()) == $actionName);

@tux-rampage tux-rampage added this to the 1.1.0 milestone Jun 8, 2015
@tux-rampage tux-rampage self-assigned this Jun 8, 2015
@tux-rampage tux-rampage modified the milestones: 1.0.3, 1.1.0 Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants