Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resuming optimization breaks with non-string feasible values #96

Open
UnsignedByte opened this issue May 22, 2024 · 0 comments
Open

Resuming optimization breaks with non-string feasible values #96

UnsignedByte opened this issue May 22, 2024 · 0 comments

Comments

@UnsignedByte
Copy link

if elem == self.feasible_output_true:
to_return.append(True)
elif elem == self.feasible_output_false:
to_return.append(False)
else:
print(
"Error: parsing the feasible data, the value given in the input dataset doesn't correspond to the values declared in the json file."
)
exit(1)

These lines check if the values read from the resume CSV match the values expected, but fails to consider the fact that reading from the csv automatically turns every value into a string, which breaks the feasible predictor for non-string feasible values. Instead, the line should be elem == str(self.feasible_output_true).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant