Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug in bounding box sample function #92

Open
bbudescu opened this issue Jul 19, 2023 · 0 comments
Open

Potential bug in bounding box sample function #92

bbudescu opened this issue Jul 19, 2023 · 0 comments

Comments

@bbudescu
Copy link

Not sure if this is actually wrong, but the code here looks a bit weird. I'm thinking it might be an indentation error, i.e., the two lines are overindented by one tab.

I'm thinking the idea was to check, after going through all objectives, for the corner case that every lower bound is equal to its respective upper bound, and, in that case, avoid having a zero divisor when normalizing below. The current implementation actually achieves this objective (whether intentionally or not) by assigning a total weight of 1 if the first objective happens to have identical bounds. Now, one of the side effects would be that the weights don't sum up to 1 any more.

Again, not sure this is intended or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant