Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speculative Decoding State Reversion after Rejection #3

Open
breaddaerb opened this issue Jun 6, 2024 · 0 comments
Open

Speculative Decoding State Reversion after Rejection #3

breaddaerb opened this issue Jun 6, 2024 · 0 comments

Comments

@breaddaerb
Copy link

Hi, I've been working with the speculative decoding implementation in the provided codebase. I'm curious about the output sequence out when the predictions made by the smaller model (small_net) are rejected by the larger model (net). Upon a rejection, we should revert the state of out to its condition prior to the rejected predictions. However, it appears that the current implementation of speculative_decoding function does not perform this state reversion.
Say if the original seq_len is 128 and gamma is 5, if all of them are rejected then in this iteration the seq_len should be 128+1, but not 128+5+1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant