Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git-send-branch recover/cache cover letters #11

Open
guludo opened this issue Jun 19, 2015 · 3 comments
Open

Make git-send-branch recover/cache cover letters #11

guludo opened this issue Jun 19, 2015 · 3 comments

Comments

@guludo
Copy link
Collaborator

guludo commented Jun 19, 2015

When using git-send-branch and some error occurs when sending the e-mails, if the user issue the command again, the user has to rewrite the cover letter.

There's a workaround for that problem, which is by manually recovering what is inside .git/.send_branch/ before git-send-branch erases it.

It would be nice if git-send-branch was smart enough to recover the cover letter (notice the pun :P) when it realizes that it couldn't send e-mails the last time it was called for the same branch and base branch.

Or even better: it could maintain a cache of cover letters in case the user is with reviews in progress for multiple branches.

Does that make sense?

@lucasdemarchi
Copy link
Owner

@guludo nice. Will you do it? :)

@cmarcelo
Copy link
Collaborator

Both ideas sound good to me: recovering from error and reusing cover letter in new versions of a branch.

@guludo
Copy link
Collaborator Author

guludo commented Jun 21, 2015

@lucasdemarchi tentatively ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants