Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera of the localplayer spins when disabling touch controls in android. #15727

Closed
astra0081X opened this issue Jan 28, 2025 · 8 comments
Closed
Labels
Android Bug Issues that were confirmed to be a bug @ Client / Controls / Input Regression Something that used to work no longer does
Milestone

Comments

@astra0081X
Copy link

astra0081X commented Jan 28, 2025

Luanti version

Luanti 5.11-dev (Downloaded from GitHub Actions: https://github.com/luanti-org/luanti/actions/runs/12998173036)

Operating system and version

Lineage OS 17.1 (Unofficial, https://xdaforums.com/t/rom-unofficial-lineage-os-17-1.4252127)
Redmi 6A (cactus)

CPU model

4x 2.0 GHz ARM Cortex-A53

GPU model

IMG PowerVR GE8320, 650 MHz

Active renderer

ES 3.2 / ogles2 / SDL

Summary

The camera of the localplayer spins when changing the touchscreen controls(settings:touch_controls) to “disabled”.

Steps to reproduce

  1. Join a single player world
  2. Open the in-game settings menu
  3. Go into “Touchscreen”
  4. You will find Touch controls (which is set to "auto" by default)
  5. Set it to "disabled"
@NNlk05
Copy link

NNlk05 commented Jan 29, 2025

Hmmm, that happened to me too, on desktop, when I afk when pause the game...

@NNlk05
Copy link

NNlk05 commented Jan 29, 2025

The fix is to exit to menu and reload

@astra0081X
Copy link
Author

Re enabling touch controls fixed it on my end

@grorp
Copy link
Member

grorp commented Jan 29, 2025

If this is a regression, it would probably be from #15697 @sfan5. I cannot test this currently, obviously it worked for me when I implemented the feature, but this could also be device/setup-specific.

@grorp
Copy link
Member

grorp commented Feb 1, 2025

Tested on my phone, 45c5ef8 has the camera spinning, the commit before (282c81f) doesn't have. Note: I did not have a mouse connected to my phone.

@grorp grorp added Bug Issues that were confirmed to be a bug Regression Something that used to work no longer does and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Feb 1, 2025
@grorp grorp added this to the 5.11.0 milestone Feb 1, 2025
@sfan5
Copy link
Collaborator

sfan5 commented Feb 1, 2025

Easy to fix then, enable relative mode on android.

sfan5 added a commit to sfan5/luanti that referenced this issue Feb 3, 2025
@astra0081X
Copy link
Author

Issue’s fixed now, great 👍

@sfan5 sfan5 reopened this Feb 3, 2025
@sfan5
Copy link
Collaborator

sfan5 commented Feb 3, 2025

Please keep the issue open until the fix is merged for tracking purposes.

@sfan5 sfan5 closed this as completed in 88b0079 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Bug Issues that were confirmed to be a bug @ Client / Controls / Input Regression Something that used to work no longer does
Projects
None yet
Development

No branches or pull requests

5 participants