Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log who has done the action (audit trail) #72

Closed
coudot opened this issue Feb 6, 2023 · 6 comments
Closed

Log who has done the action (audit trail) #72

coudot opened this issue Feb 6, 2023 · 6 comments
Assignees
@coudot
Labels
enhancement New feature or request
Milestone
0.5

Comments

@coudot
Copy link
Member

coudot commented Feb 6, 2023

For now, access to Service Desk is anonymous, even if we recommend to add authentication (Web Server or SSO).

We should be able to get the identity of connected user and log every action done.
@coudot coudot added the enhancement New feature or request label Feb 6, 2023
@coudot coudot added this to the 0.5 milestone Feb 6, 2023
@coudot
Copy link
Member Author

coudot commented Feb 6, 2023

See also discussions in #21

@coudot coudot mentioned this issue Feb 6, 2023
Closed
@coudot
Copy link
Member Author

coudot commented Feb 7, 2023

Duplicate of #41

@coudot coudot marked this as a duplicate of #41 Feb 7, 2023
@coudot coudot mentioned this issue Feb 7, 2023
Closed
@artlog
Copy link

artlog commented Feb 20, 2023

Taking a look

artlog pushed a commit that referenced this issue Feb 20, 2023
@philhaworteks
basic audit in json when passwordchanged #72
cec27ba 
- create a json audit line to audit_file if opened when password is succesfully changed.
- configuration :
  - it is required to set $audit_file=fopen(<audit_file>, "a"); in config.inc.local.php
@coudot
Copy link
Member Author

coudot commented Mar 9, 2023

Hello @artlog

I would have seen an easier solution to begin: use the admin name in the logs (with error_log -> https://www.php.net/manual/fr/function.error-log.php)

@coudot
Copy link
Member Author

coudot commented Apr 21, 2023

After discussions with several people, storing JSON in an audit file is a correct solution.

I will propose something slightly different that the format used in commit cec27ba

@coudot
Copy link
Member Author

coudot commented Apr 24, 2023

Done in commits 8a36b87 and 736b5fc

@coudot coudot closed this as completed Apr 24, 2023
@coudot coudot self-assigned this Apr 24, 2023
@coudot coudot mentioned this issue May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coudot coudot

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@coudot @artlog