Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback / Enhancement ideas #24

Open
Windows-Key opened this issue Dec 9, 2023 · 3 comments
Open

Feedback / Enhancement ideas #24

Windows-Key opened this issue Dec 9, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Windows-Key
Copy link

Hey Łukasz,

I've been using mi-scale-exporter for a few weeks now and I wanted to give you some quick feedback, as well as some ideas for potential enhancements since my use case is probably a bit different from most people's (ie. I am not using a Mi scale).

First of, mi-scale-exporter works great for me. No bugs, no crashes, it just works flawlessly.

I have been keeping notes of the little things you only notice while actively using something these past few weeks. Perhaps, some of the feedback is useful. In any case, thanks again for making this app.

MFA
MFA works really well now. I only have a couple of suggestions for making it even better:

  1. Since Garmin MFA codes are numeric, maybe it's possible to default to a numeric keypad as well (therefore making it easier to enter the MFA code).
  2. Some apps offer to input the MFA code automatically for you (ie. autofill). As I understand it, this requires an additional permission. It's probably not worth it to implement this, unless it's no fuzz.
  3. (Google Messages offers an option to copy MFA codes to the clipboard from the notification bar. This works for Paypal MFA, for instance but it does not work for Garmin codes - at least not for me. I suspect this is something Garmin would have to address though. Just thought I'd mention it for the sake of completeness.)

Usability

  1. As I mentioned, I don't have a Mi Scale and I use mi-scale-exporter to manually enter the values. And that works great. Perhaps it would be possible to have the app open on the screen that was last used which, for me, would always be "Garmin Form".
  2. Now we're getting into nit-pick territory: my scale doesn't display some information the mi scale apparently does (like "body age"). Maybe it would be possible to a preference dialogue for selecting which data fields are displayed in the UI. I realize, at that point, we're kind of pivoting away from the original purpose of the app (making the Mi Scale usable with Garmin) to more of a generic approach (making any scale usable with Garmin) though.
  3. On the help screen, it still says that MFA isn't supported which is no longer true (as it works great).

Thanks!

@lswiderski lswiderski added the enhancement New feature or request label Dec 10, 2023
@lswiderski
Copy link
Owner

Hi @Windows-Key

Thanks for feedback. You have good idea with that points.

MFA 1: 👍
MFA 2&3: I think It can only possible for SMS codes but not for Emails.

Usability 1 👍
Usability 2: Data fields in that page comes from Garmin .FIT activity schema and Garmin expect to get all of them, but expect does not mean require. So even when user do not fill anything in same field, It would be passed to Garmin as empty. I do not want to block some fields If you do not have that field, just ignore them.

About point Usability 3. Yea, I know I wanted to release MFA support as fast it was possible so that version contains some minor bugs.

My activity slowed down because of my personal/family reason but when I will find some time I will try to implement that ideas

@Windows-Key
Copy link
Author

Hi Łukasz,

thanks again for your quick response.

No worries, family comes first. Thanks for your great work.

Oh, and since I didn't mention it above: Garmin sends MFA codes by text message (SMS) in my market. I am not sure there was even an option for e-mail when I signed up. I suppose it varies by location though.

Take care!

@Alex0007
Copy link

Alex0007 commented May 5, 2024

Hi @lswiderski

Thanks for this app!

  • Is auto upload mode possible to implement?
  • Why app asks for age instead of date of birth? Age input means it will be invalid in less than 365 days
  • For some reason there is an incorrect Time of measurement value in upload form (value is always the same and not changed between measurements). Time of measurement is always equal to the time of first application run after install and never changes. UPD.: it is the same only if you pressed "Stop Measure".
  • Is it possible to send only weight without BMI, as shown in Garmin Connect upload form (i have simple scale version and my other parameters are more actualized in garmin connect itself)
  • In case scale haven't provided the body fat metrics – an app sends 0 value to Garmin which is incorrect
Screenshot 2024-05-05 at 20 01 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants