DM-54227: Allow for more than requested bands to be supplied#1274
DM-54227: Allow for more than requested bands to be supplied#1274
Conversation
| imageBArray = np.zeros(shape, dtype=np.float32) | ||
|
|
||
| for band, image in channels.items(): | ||
| if band not in self.config.channelConfig: |
There was a problem hiding this comment.
Thanks for adding this. I forgot something like this was on a branch from DP1 around FL, and just came across it too while porting things back from that whole mess. However, by this time the data has already been pulled from the butler. If you make the change down below in my other comment, it will save memory and run time.
There was a problem hiding this comment.
This could be done in adjustQuantum instead, to slightly shrink the QG and keep the task from being blocked by an upstream failure in an irrelevant band. Probably not worth it for this ticket, this late in the game.
| """ | ||
| sortedImages: dict[str, Exposure] = {} | ||
| for ref in refs: | ||
| key: str = cast(str, ref.dataId["band"]) |
There was a problem hiding this comment.
if you check and continue here, the get call will never happen for bands we don't need.
There was a problem hiding this comment.
Ah sorry, right in makeInputsFromRefs in PrettyPictureTask
yalsayyad
force-pushed
the
tickets/DM-54227
branch
from
52652fd to
5187eea
Compare
Arrays in assemble_sub_region don't match otherwise
| imageBArray = np.zeros(shape, dtype=np.float32) | ||
|
|
||
| for band, image in channels.items(): | ||
| if band not in self.config.channelConfig: |
There was a problem hiding this comment.
This could be done in adjustQuantum instead, to slightly shrink the QG and keep the task from being blocked by an upstream failure in an irrelevant band. Probably not worth it for this ticket, this late in the game.
3 participants
No description provided.