joinUrl is not a function

[sirajtahrawashmen]

we are using webpack for our module bundling, and there is one error caused by this library.

in file 'src/url.js' you are requiring the proper-url-join const joinUrl = require('proper-url-join');

this is importing the module instead of the function.

Possible Solutions:

• use import urlJoin from 'proper-url-join'; instead
• use const joinUrl = require('proper-url-join').default instead

references:
https://www.npmjs.com/package/proper-url-join
https://stackoverflow.com/questions/33683539/webpack-require-is-not-a-function-when-using-babel-6

[lsabbagh]

Hello Siraj.
Thank you for this...
However, It is not clear yet, adding .default will never fix it...
check this line:
https://github.com/lsabbagh/faxios/blob/master/lib/url.js#L48
.default is used when calling...
Can you add more details about the bug? and details about how you solved it so it will make it clearer?