Chore: Exercise Overview adjustments and PR cleanup
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gic from SinglePageConversationBody
FelberMartin
requested changes
Nov 14, 2024
.../kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/exercise/ExerciseActionButtons.kt
Outdated
Show resolved
Hide resolved
.../kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/exercise/ExerciseActionButtons.kt
Outdated
Show resolved
Hide resolved
...de/tum/informatics/www1/artemis/native_app/core/ui/material/colors/exercise_action_colors.kt
Outdated
Show resolved
Hide resolved
...nformatics/www1/artemis/native_app/feature/exerciseview/home/overview/ExerciseOverviewTab.kt
Outdated
Show resolved
Hide resolved
...nformatics/www1/artemis/native_app/feature/exerciseview/home/overview/ParticipationStatus.kt
Outdated
Show resolved
Hide resolved
FelberMartin
approved these changes
Nov 15, 2024
FelberMartin
requested changes
Nov 15, 2024
.../kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/exercise/ExerciseActionButtons.kt
Outdated
Show resolved
Hide resolved
Could you check again? I was not able to reproduce this issue. The changes could be resolved now, as the buttons are not displayed anymore. |
FelberMartin
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
The issue indeed seems to be fixed by now.
However I noticed, that the Exercise titles are not displayed anymore, but it seems that this is an issue on develop aswell. If you know how this could be fixed quickly we could include it in this PR, otherwise let's create a separate issue for this.
EDIT: I just noticed that this is a bug on the develop branch, I'll create an issue for it.
TimOrtel
requested changes
Nov 19, 2024
...tum/informatics/www1/artemis/native_app/feature/exerciseview/home/ExerciseScreenTopAppBar.kt
Show resolved
Hide resolved
...tum/informatics/www1/artemis/native_app/feature/exerciseview/home/ExerciseScreenTopAppBar.kt
Outdated
Show resolved
Hide resolved
.../informatics/www1/artemis/native_app/feature/metis/ui/SinglePageConversationBodyViewModel.kt
Outdated
Show resolved
Hide resolved
.../informatics/www1/artemis/native_app/feature/metis/ui/SinglePageConversationBodyViewModel.kt
Outdated
Show resolved
Hide resolved
.../feature/metis/manageconversations/ui/conversation/overview/ConversationOverviewViewModel.kt
Outdated
Show resolved
Hide resolved
julian-wls
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is follow-up PR to #42 in order to resolve some minor problems, that were pointed out here. Logic has been extracted into view models and strings have been replaced with resource strings. Furthermore, it introduces modifications to the exercise overview and fixes design issues (see screenshots).
Merging this branch will solve #75
Screenshots
Before:
After: