Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use ArtemisImageProvider everywhere + Update to coil3 #163

Open
FelberMartin opened this issue Nov 28, 2024 · 0 comments
Open

Chore: Use ArtemisImageProvider everywhere + Update to coil3 #163

FelberMartin opened this issue Nov 28, 2024 · 0 comments
Assignees
Labels
chore House keeping; non-functional, non-visual changes

Comments

@FelberMartin
Copy link
Collaborator

Description

While working on #111 I introduced the new ArtemisImageProvider class which should be used to load all image related resources. I discovered that using the ArtemisImageProvider for loading course icons works, but there is a problem with the PlayStoreScreenshots. In order to intercept the ImageRequests the recommended way is to use a AsyncImagePreviewHandler which comes with coil3.

Updating the dependency and using the new ArtemisImageProvider everywhere seemed to blow up the PR, so lets tackle this separately.

Next steps

@FelberMartin FelberMartin added the chore House keeping; non-functional, non-visual changes label Nov 28, 2024
@FelberMartin FelberMartin self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore House keeping; non-functional, non-visual changes
Projects
None yet
Development

No branches or pull requests

1 participant