Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Show exercise title #126

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

There was a bug that the exercise titles where not shown, see #120 .

Changes

  • Showing exercise title
  • Removed the collapsible ExerciseTopAppBar
  • Rearrange ExerciseInfo to ExerciseOverviewTab.kt

Screenshots

Phone
image
Tablet
image
Foldable
image

… with iOS design; rearrange ExerciseInfo to ExerciseOverviewTab.kt
@FelberMartin FelberMartin linked an issue Nov 20, 2024 that may be closed by this pull request
@FelberMartin FelberMartin self-assigned this Nov 20, 2024
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Nov 23, 2024
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, didn't experience a missing title while testing. Code lgtm.

@FelberMartin FelberMartin merged commit 1940e8e into chore/cleanupPR Nov 29, 2024
5 checks passed
@FelberMartin FelberMartin deleted the bugfix/show-exercise-title branch November 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Exercise title not shown
2 participants