Bugfix: Fix post insertion for live created posts
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelberMartin
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Tested and the bug does not occur anymore.
Could you please add a test to ensure the proper functionality? You may use a similar structure as in the test introduced in #96
TimOrtel
requested changes
Nov 27, 2024
...rtemis/native_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceImpl.kt
Outdated
Show resolved
Hide resolved
...e_app/feature/metis/conversation/service/storage/impl/MetisStorageServiceTestLiveCreation.kt
Outdated
Show resolved
Hide resolved
julian-wls
added
ready to merge
FelberMartin
approved these changes
Nov 29, 2024
FelberMartin
deleted the
bugfix/communication/fix-message-live-inserting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
When having a channel open and receiving a post from another channel the post gets saved into the currently opened channel. This PR fixes this issue by inserting the correct conversationId into the database. This PR fixes #115
Changes
MetisStorageService has been updated to save the correct conversationId for the post.
Steps for testing