Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Dark Mode Divider Visibility Issue by Updating Surface Colors #102

Open
FelberMartin opened this issue Nov 14, 2024 · 0 comments
Open
Labels
chore House keeping; non-functional, non-visual changes improvement Minor improvements, no new functionality

Comments

@FelberMartin
Copy link
Collaborator

FelberMartin commented Nov 14, 2024

Description

This follow-up issue to the problem discovered in this PR discussion aims to resolve the divider visibility problem in dark mode due to the M3 design specification flaw. Specifically, the colors surfaceVariant and outlineVariant are both mapped to neutral-variant30, making dividers invisible in dark mode.

In #76 we quickly fixed this issue by assigning a different value to outlineVariant for dark mode

Tasks

  • Dependency Update: Upgrade to the latest M3 version that includes surfaceContainer (or another suitable alternative) if available.
  • Replace SurfaceVariant: Update all instances of surfaceVariant with surfaceContainer (or another suitable color).
  • UPDATE: As discussed in the communication team meeting and with Ramona, disable the dynamic color schemes for the android app as we value the consistency of Artemis apps over the Android user customizability
@FelberMartin FelberMartin added improvement Minor improvements, no new functionality chore House keeping; non-functional, non-visual changes labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore House keeping; non-functional, non-visual changes improvement Minor improvements, no new functionality
Projects
None yet
Development

No branches or pull requests

1 participant