Fix package import for ArchUnit

Author: sarpsahinalp

src/main/java/de/tum/cit/ase/ares/api/architecture/java/archunit/postcompile/JavaArchitectureTestCaseCollection.java

@@ -96,10 +96,10 @@ public static String getArchitectureRuleFileContent(String key) {
     public static ArchRule noClassesShouldImportForbiddenPackages(Set<String> allowedPackages) {
         return ArchRuleDefinition.noClasses()
                 .should()
-                .transitivelyDependOnClassesThat(new DescribedPredicate<>("imports package") {
+                .dependOnClassesThat(new DescribedPredicate<>("imports package") {
                     @Override
                     public boolean test(JavaClass javaClass) {
-                        return allowedPackages.stream().allMatch(allowedPackage -> allowedPackage.startsWith(javaClass.getPackageName()));
+                        return allowedPackages.stream().noneMatch(allowedPackage -> javaClass.getPackageName().startsWith(allowedPackage));
                     }
                 });
     }

src/main/java/de/tum/cit/ase/ares/api/securitytest/java/JavaSecurityTestCaseFactoryAndBuilder.java

@@ -22,10 +22,7 @@
 import javax.annotation.Nonnull;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.List;
+import java.util.*;
 import java.util.function.Supplier;
 import java.util.stream.IntStream;
 import java.util.stream.Stream;

src/test/resources/de/tum/cit/ase/ares/integration/testuser/securitypolicies/EverythingForbiddenPolicy.yaml

@@ -11,6 +11,10 @@ regardingTheSupervisedCode:
       - importTheFollowingPackage: "java.io"
       - importTheFollowingPackage: "java.lang"
       - importTheFollowingPackage: "java.util"
-      - importTheFollowingPackage: "de.tum.cit.ase.ares.api.aop.aspectj.adviceandpointcut"
-      - importTheFollowingPackage: "java.nio.file"
+      - importTheFollowingPackage: "de.tum.cit.ase.ares.api.aop.java.aspectj.adviceandpointcut"
+      - importTheFollowingPackage: "java.nio"
       - importTheFollowingPackage: "org.java.aspectj"
+      - importTheFollowingPackage: "org.aspectj"
+      - importTheFollowingPackage: "jdk.internal"
+      - importTheFollowingPackage: "java.net"
+      - importTheFollowingPackage: "sun.reflect"

src/test/resources/de/tum/cit/ase/ares/integration/testuser/securitypolicies/OnePathAllowed.yaml

@@ -18,6 +18,10 @@ regardingTheSupervisedCode:
       - importTheFollowingPackage: "java.io"
       - importTheFollowingPackage: "java.lang"
       - importTheFollowingPackage: "java.util"
-      - importTheFollowingPackage: "de.tum.cit.ase.ares.api.aop.aspectj.adviceandpointcut"
-      - importTheFollowingPackage: "java.nio.file"
+      - importTheFollowingPackage: "de.tum.cit.ase.ares.api.aop.java.aspectj.adviceandpointcut"
+      - importTheFollowingPackage: "java.nio"
       - importTheFollowingPackage: "org.java.aspectj"
+      - importTheFollowingPackage: "org.aspectj"
+      - importTheFollowingPackage: "jdk.internal"
+      - importTheFollowingPackage: "java.net"
+      - importTheFollowingPackage: "sun.reflect"