Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Separate personal and guild achievement toast types #59

Closed
Taizunz opened this issue Apr 14, 2024 · 1 comment
Closed

Comments

@Taizunz
Copy link

Taizunz commented Apr 14, 2024

I'd love to be able to disable guild achievements as there appears to be a UI bug where some old guild achievements re-pop from time to time.
At the moment this doesn't appear to be possible in LS Toasts as guild and personal achievements aren't separated, hence I'm requesting the separation of these so each type can be configured to the users liking.

ls- added a commit that referenced this issue Sep 11, 2024
@ls-
Copy link
Owner

ls- commented Sep 11, 2024

Fixed, it'll be released with the next update, but not today.

@ls- ls- closed this as completed Sep 11, 2024
ls- added a commit that referenced this issue Sep 25, 2024
This bug is rather interesting. While the API no longer returns the
actual faction of the guild, there still seems to be the primary faction
for every guild, if anything, it's entirely possible that under the hood
there's 2 guilds, one for horde members and one for ally, but they're
presented as one to users. The guild achievement spam is caused by
achievements of the secondary faction, so in a horde guild people will
be spammed with ally achievements and vice versa. For whatever reason
they get reset regularly, and whenever someone logs in they pop.
Ref: #59, #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants